Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in exclusion filtering #4

Merged
merged 2 commits into from
May 21, 2020

Conversation

codders
Copy link

@codders codders commented May 21, 2020

Exclusions code was returning no exposes if no exclusions were configured
Added test for Hunter class

@codders codders requested a review from mordax7 May 21, 2020 11:48
@codders codders force-pushed the bugfix/fix-empty-filter branch from 90e2035 to 284f635 Compare May 21, 2020 11:49
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #4 into master will increase coverage by 10.07%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
+ Coverage   49.16%   59.24%   +10.07%     
===========================================
  Files           7        7               
  Lines         421      422        +1     
  Branches       49       49               
===========================================
+ Hits          207      250       +43     
+ Misses        206      158       -48     
- Partials        8       14        +6     
Impacted Files Coverage Δ
flathunter/hunter.py 38.38% <84.61%> (+38.38%) ⬆️
flathunter/crawl_immowelt.py 63.76% <0.00%> (+7.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcfe966...5a2581d. Read the comment docs.

@mordax7
Copy link

mordax7 commented May 21, 2020

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants