Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esx: Optionally read static IP config from ESX profile #98

Merged
merged 3 commits into from
Apr 24, 2020

Conversation

pothos
Copy link
Member

@pothos pothos commented Apr 24, 2020

  • esx: Optionally read static IP config from ESX profile
    Instead of a long list of command line options, the static IP configuration
    should be part of the config file.
    The values can be left out and the command line options get preference.
  • esx: Always remove created VM on error
  • esx: Free static IP up when device creation failed

pothos added 2 commits April 24, 2020 13:19
Instead of a long list of command line options, the static IP configuration
should be part of the config file.
The values can be left out and the command line options get preference.
@pothos pothos requested a review from a team April 24, 2020 11:34
Copy link
Contributor

@margamanterola margamanterola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pothos pothos merged commit dc82a1a into flatcar-master Apr 24, 2020
@pothos pothos deleted the kai/esx-config branch April 24, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants