Switch to Hyperkube v1.14+. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from Docker 19.03, we need a newer version of Kubernetes or our deployment doesn't work. So we switch to testing newer k8s versions. This includes updating quite a few Kubernetes flags that were deprecated since the old version we were using, to use the new names and formats. Supporting different Kubernetes versions also means adding some conditional behavior for commands that changed along the way. This commit also switches to the hyperkube images provided by gcr.io instead of the ones provided by quay.io, as those were discontinued. To get this to work we need to prepend the ACI with docker:// and set the --insecure-options=image option (See coreos/coreos-kubernetes#583) It also updates the environment variables in the service files to the non-deprecated ones wanted by kubelet-wrapper. And it adds a few plog messages while setting up to make the kola output more helpful.
pothos
reviewed
Apr 16, 2020
|
I tested on Stable and it passed 👍 You have to run |
pothos
approved these changes
Apr 16, 2020
margamanterola
force-pushed
the
marga-kinvolk/update-k8s-test
branch
from
fef4786 to
3d22d5e
Compare
|
Applied gofmt, sorry about that, I'll make sure I add this as a hook in my editor so I don't forget. |
pothos
approved these changes
Apr 16, 2020
dongsupark
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt our existing kubernetes test to newer versions
Starting from Docker 19.03, we need a newer version of Kubernetes or our deployment doesn't work. So we switch to testing newer k8s versions.
This includes updating quite a few Kubernetes flags that were deprecated since the old version we were using, to use the new names and formats (some flags were renamed, others had to be moved to config files, others don't exist anymore). Supporting different Kubernetes versions also means adding some conditional behavior for commands that changed along the way.
This commit also switches to the hyperkube images provided by gcr.io instead of the ones provided by quay.io, as those were discontinued. To get this to work we need to prepend the ACI with docker:// and set the --insecure-options=image option (See coreos/coreos-kubernetes#583)
It also updates the environment variables in the service files to the non-deprecated ones wanted by kubelet-wrapper.
And it adds a few plog messages while setting up to make the kola output more helpful.
How to run
bin/kola run --basename=new-kube --gce-image=marga-test-2466-0-0 --gce-json-key=gce-service-account.json --parallel=4 --platform=gce -d -k --remove=false --torcx-manifest=torcx_manifest.json google.kubernetes.basic.docker.v1.16.8 google.kubernetes.basic.docker.v1.18.0 google.kubernetes.basic.docker.v1.14.10Testing done
I've run the command listed above and it passed for all three versions of Hyperkube (after a lot of tweaking the setup...)
Fixes: flatcar/Flatcar#79