Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: increase cgroup memory limit to 50MB #80

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

dongsupark
Copy link
Member

With 30MB, docker run still fails in some cases.
Let's increase the cgroup memory limit to 50MB, to avoid such failures.

Other details are already described in #79.

With 30MB, docker run still fails in some cases.
Let's increase the cgroup memory limit to 50MB, to avoid such failures.

Other details are already described in
#79.
@dongsupark dongsupark added the bug Something isn't working label Apr 9, 2020
@dongsupark dongsupark requested a review from a team April 9, 2020 10:19
@pothos
Copy link
Member

pothos commented Apr 9, 2020

What about --shm-size=1m, --memory-reservation=10m, and --kernel-memory=10m? Maybe those could be related to the crash?

@dongsupark
Copy link
Member Author

I am not sure I understand the question.

In the code, each line is interpreted as a set of parameters for each docker run command. So each line is independent of each other.
--kernel-memory=10m becomes docker run --kernel-memory=10m, and it has nothing to do with the --memory option.

AFAIK there has been no case where the --kernel-memory=10m test failed.
Failed one was either --memory=30m --memory-swap=30m or --memory=30m --oom-kill-disable=true.

@pothos
Copy link
Member

pothos commented Apr 9, 2020

Ok, thanks for explaining!

@t-lo t-lo merged commit d446b09 into flatcar-master Apr 9, 2020
@t-lo t-lo deleted the dongsu/increase-docker-memory-limit-50m branch April 9, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants