kola network.go: fix cl.network.listeners proc truncate #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test cl.network.listeners checks for active listener sockets.
It uses `netstat -plutn` to list listeners which may truncate the
program name. Since the output is compared to predefined strings
the test may fail if the combination of PID, "/", and program
name exceeds 19 characters.
This change truncates the expected string to the constraints lined
out above, which fixes the test.
To reproduce the error, run this test e.g. on Azure, where it
reproducibly fails because the PID of systemd-networkd has
4 digits:
```
bin/kola run cl.network.listeners --platform azure --azure-disk-uri <flatcar-image-URI> --azure-location <location-of-image>
```
For testing, the following URI / location may be used:
URI: /subscriptions/d38033ba-ec21-470c-96cf-4c6db9658d8b/resourceGroups/flatcar-release-testing-francecentral/providers/Microsoft.Compute/images/flatcar-linux-2345.3.0-stable-release-testing-francecentral
location: francecentral
Currently the test fails with:
```
=== RUN cl.network.listeners
--- FAIL: cl.network.listeners (581.85s)
network.go:120: full netstat output: "Active Internet connections (only servers)\nProto Recv-Q Send-Q Local Address Foreign Address State PID/Program name \ntcp6 0 0 :::22 :::* LISTEN 1/systemd \nudp 0 0 10.0.0.4:68 0.0.0.0:* 1082/systemd-networ"
network.go:120: full netstat output: "Active Internet connections (only servers)\nProto Recv-Q Send-Q Local Address Foreign Address State PID/Program name \ntcp6 0 0 :::22 :::* LISTEN 1/systemd \nudp 0 0 10.0.0.4:68 0.0.0.0:* 1082/systemd-networ"
network.go:120: full netstat output: "Active Internet connections (only servers)\nProto Recv-Q Send-Q Local Address Foreign Address State PID/Program name \ntcp6 0 0 :::22 :::* LISTEN 1/systemd \nudp 0 0 10.0.0.4:68 0.0.0.0:* 1082/systemd-networ"
network.go:138: Unexpected listener process: "udp 0 0 10.0.0.4:68 0.0.0.0:* 1082/systemd-networ"
```
After applying the change the test succeeds:
```
=== RUN cl.network.listeners
--- PASS: cl.network.listeners (408.91s)
```
Signed-off-by: Thilo Fromm <[email protected]>
|
Please append the |
Signed-off-by: Thilo Fromm <[email protected]>
Done. |
pothos
approved these changes
Mar 11, 2020
dongsupark
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test cl.network.listeners checks for active listener sockets.
It uses
netstat -plutnto list listeners which may truncate theprogram name. Since the output is compared to predefined strings
the test may fail if the combination of PID, "/", and program
name exceeds 19 characters.
This change truncates the expected string to the constraints lined
out above, which fixes the test.
To reproduce the error, run this test e.g. on Azure, where it
reproducibly fails because the PID of systemd-networkd has
4 digits:
For testing, the following URI / location may be used (transient, images will be removed eventually):
Currently the test fails with:
After applying the change the test succeeds:
Signed-off-by: Thilo Fromm [email protected]