kola: Improve debugging abilities through SSH login #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
force-pushed
the
kai/fix-gce-variable
branch
2 times, most recently
from
b821e1d to
f4a169c
Compare
|
Tests are now starting additional machines with cloud-config but there the bash script errors. To debug this I need a way to tell kola to use an additional SSH key besides the random key that it generates. |
pothos
changed the title
The tests in "kola run" used a temporary SSH key and directly deleted the machines after a failure. Add the same SSH key option as in "kola spawn" to include additional SSH keys (just "-k" is enough to include the agent/default SSH keys). Also use the option to skip machine removal as in "kola spawn --remove=false".
pothos
force-pushed
the
kai/fix-gce-variable
branch
from
2698019 to
b68e0fd
Compare
Use the private IP because the default firewall rules do not allow incoming traffic on 2379 for the public IP. Also, there are no FLATCAR_*_IP* variables set up in /etc/environment for machines running in Google Compute Engine because (as with afterburn) the prefix is still COREOS_.
pothos
force-pushed
the
kai/fix-gce-variable
branch
from
b68e0fd to
96f71af
Compare
|
The Kubernetes test passes, I'm quite surprised that it isn't outdated :) |
dongsupark
approved these changes
Mar 6, 2020
There was a problem hiding this comment.
Looks good.
BTW there are probably many other places with a wrong FLATCAR_ prefix being used. From the first look, FLATCAR_ looks really correct, COREOS_ looks wrong to normal users. It is one of the corner cases that prevent us from maintaining repos in an automated way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kola: Improve debugging abilities through SSH login
The tests in "kola run" used a temporary SSH key and
directly deleted the machines after a failure.
Add the same SSH key option as in "kola spawn"
to include additional SSH keys (just "-k" is
enough to include the agent/default SSH keys).
Also use the option to skip machine removal as
in "kola spawn --remove=false".
Use the private IP because the default firewall
rules do not allow incoming traffic on 2379 for
the public IP.
Also, there are no FLATCAR__IP variables set up in
/etc/environment for machines running in
Google Compute Engine because (as with afterburn)
the prefix is still COREOS_.