Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: add more tests for Flatcar symlinks #55

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

dongsupark
Copy link
Member

We should also test more if symlinks for Flatcar exist.

  • /etc/coreos - /etc/flatcar
  • /usr/bin/coreos-install - /usr/bin/flatcar-install
  • /usr/lib/coreos - /usr/lib/flatcar
  • /usr/share/coreos - /usr/share/flatcar

For that, define a map that contains all the symlinks.

We should also test more if symlinks for Flatcar exist.

* /etc/coreos - /etc/flatcar
* /usr/bin/coreos-install - /usr/bin/flatcar-install
* /usr/lib/coreos - /usr/lib/flatcar
* /usr/share/coreos - /usr/share/flatcar

For that, define a map that contains all the symlinks.
@dongsupark dongsupark added the enhancement New feature or request label Feb 27, 2020
@dongsupark dongsupark requested a review from pothos February 27, 2020 17:10
@dongsupark dongsupark requested review from a team and removed request for pothos April 3, 2020 14:16
Copy link
Contributor

@margamanterola margamanterola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsupark dongsupark merged commit 7b473f5 into flatcar-master Apr 16, 2020
@dongsupark dongsupark deleted the dongsu/kola-symlink-tests branch April 16, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants