-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/kubeadm: add kubernetes 1.26 #406
Conversation
kola/tests/kubeadm/kubeadm.go
Outdated
"v1.26.0": map[string]interface{}{ | ||
"MinMajorVersion": 3033, | ||
// from https://github.com/flannel-io/flannel/releases | ||
"FlannelVersion": "v0.19.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember if we agreed on any policy with regards to bumping these version numbers. Have we? I'm asking because looking into the URLs in comments, I can see that flannel has version v0.20.2, cilium has 1.12.5, cilium cli has 0.12.12, cni is still v1.1.1, crictl has v1.26.0 and k8s release is still v0.14.0.
So not sure, maybe a follow-up PR if these versions work for k8s 1.26?
(Also, happy that the checksums script worked for you!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I always have the same question in mind when updating the kubernetes tests. We could update the third-party components in the same time, but I don't know if it's something commonly down: do users still run on the latest version of all software?
Ideally we would know which version of each software is the most used and we will use these versions into the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My take on these tests is that we want to test a range of k8s versions on flatcar. Since k8s needs some networking solution and these tend to be quite dependent on running kernel, we also want to test a range of networking solutions versions. So it may be a good idea to bump the versions of all this stuff at the time of a new major k8s release. It won't give 100% coverage, but should be good enough. This is in light of a realization that having data on the most used version combinations of software is a wishful thinking, not gonna happen. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped the versions:
1..3
ok - kubeadm.v1.26.0.cilium.base
ok - kubeadm.v1.26.0.flannel.base
ok - kubeadm.v1.26.0.calico.base
Kubernetes 1.26.0 is out since beginning of december. Let's cover it in the tests. Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
202b20e
to
ed2c97e
Compare
Kubernetes 1.26.0 is out since beginning of december. Let's cover it in the tests.
Signed-off-by: Mathieu Tortuyaux [email protected]
Notified while testing CAPO that 1.26 is not being tested (flatcar/Flatcar#921)
Tested on openstack with current Flatcar stable (3374.2.2):
Regarding 1.23: active support has been dropped 2 weeks ago and maintenance support will be dropped in 1 month. I think it's good to have it until end of Feb.
Thanks @krnowak for the
checksums.sh
it's quite handy, generated this PR in a minute.