Remove Fedora and Fcos code from plume #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 24, 2020 12:48
This simplifies our code base removing the bits that we're not using. Also replace CoreOS with Flatcar in the command descriptions.
This simplifies our code base by removing the unused code to prerelease Fedora images. It also replaces CoreOS with Flatcar in the command descriptions.
This simplifies our code base removing unused Fedora/Fcos functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Fedora and Fcos code from plume
Plume's code currently includes a bunch of functions to upload Fedora and Fcos images that we're not using and that gets in the way when making changes to plume. This PR removes all Fedora and Fcos functions from our code, keeping only the code that we're using for Flatcar.
It also replaces CoreOS strings with Flatcar (in command descriptions and comments, not copyright notices or github paths).
How to use / Testing done
I've only verified that the code builds, with:
go1.15.1 build -o bin/plume github.com/coreos/mantle/cmd/plume, I'm not sure how to test this properly without causing a release.