azure: use one Resource Group for all tests #114
Conversation
pothos
force-pushed
the
kai/azure-one-resource-group
branch
2 times, most recently
from
e7867a0 to
4aa0c2c
Compare
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if af.ImageResourceGroup != "" && af.ImageStorageAccount != "" { |
There was a problem hiding this comment.
If I understand this change correctly, the idea is that this is initialized the first time that this function is called, and after that it keeps re-using these values, is that correct? If so, could you add this to the function doc? Maybe "If no resource groups and storage accounts have been created for this flight yet, this will also create them" ?
There was a problem hiding this comment.
The function is called at least for every test, and it is not initializing something to reuse it. The function either uses the flight's Resource Group or creates a new one.
Added the documentation.
There was a problem hiding this comment.
Thanks for the extra docs, it makes more sense now! :)
Each kola cluster created and destroyed its own Resource Group which took 2-3 minutes. Reuse the image Resource Group if it was created for the flight and run all tests in it. To keep the amount of left over VM network objects small, the IP addresses and NICs are deleted when an instance is deleted - this could also be removed again if we see that deleting these objects takes a lot of time.
pothos
force-pushed
the
kai/azure-one-resource-group
branch
from
4aa0c2c to
a1d9910
Compare
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if af.ImageResourceGroup != "" && af.ImageStorageAccount != "" { |
There was a problem hiding this comment.
Thanks for the extra docs, it makes more sense now! :)
Each kola cluster created and destroyed its own Resource Group which
took 2-3 minutes.
Reuse the image Resource Group if it was created for the flight and
run all tests in it. To keep the amount of left over VM network objects
small, the IP addresses and NICs are deleted when an instance is
deleted - this could also be removed again if we see that deleting
these objects takes a lot of time.
How to use/testing done