Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola/tests/locksmith/locksmith: Make coreos.locksmith.tls more robust #111

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

pothos
Copy link
Member

@pothos pothos commented Jun 12, 2020

On VMware ESXi there were reproduceable test failures with kola due to
the certificate date ("certificate is not yet valid") but these
failures were not reproducible by executing the same commands manually.
Cover the failing command in a rety loop because I suspect that the
system time got slightly adjusted or something similar in between
which causes the certificate to be invalid for a short time.

How to use/test

./cork download-image --cache-dir=tmp --json-key=/dev/null --platform=esx --root=gs://flatcar-jenkins/beta/boards/amd64-usr/2513.2.1
./ore esx --esx-config-file esx.json remove-vms
./kola run -d --esx-config-file esx.json --esx-ova-path tmp/flatcar_production_vmware_ova.ova --parallel=4 --platform=esx --channel=beta --tapfile=vmware-esx.tap coreos.locksmith.tls

On VMware ESXi there were reproduceable test failures with kola due to
the certificate date ("certificate is not yet valid") but these
failures were not reproducible by executing the same commands manually.
Cover the failing command in a rety loop because I suspect that the
system time got slightly adjusted or something similar in between
which causes the certificate to be invalid for a short time.
@pothos pothos requested a review from a team June 12, 2020 14:06
Copy link
Member

@t-lo t-lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge and re-run the coreos.locksmith.tls test on vmware.

@pothos pothos merged commit 456aa8a into flatcar-master Jun 15, 2020
@pothos pothos deleted the kai/retry-cert-clock branch June 15, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants