developer builds: Get images from channel subdirectory (and update vendor folder to fix build) #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paths for image files and the binary package store were the same for developer builds because the images were created directly under the developer root path of the bucket instead of ROOTPATH/CHANNEL/. Use the path developer/developer which is ROOTPATH/CHANNEL/ because "developer" also happens to be the channel name and not only the developer root path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developer builds: Get images from channel subdirectory
The paths for image files and the binary package store were the same
for developer builds because the images were created directly under
the developer root path of the bucket instead of ROOTPATH/CHANNEL/.
Use the path developer/developer which is ROOTPATH/CHANNEL/
because "developer" also happens to be the channel name and not
only the developer root path.
The second commit was just a
make vendorbecause it wasn't done in another PR and broke the Jenkins build.How to use
Run the plume pre-release command as Jenkins does.
Testing done
I ran the command and saw that the download started, then stopped.