Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola/tests/docker: Skip no-new-privileges test for Docker 1.12 #108

Merged
merged 1 commit into from
May 26, 2020

Conversation

pothos
Copy link
Member

@pothos pothos commented May 26, 2020

Recently two Docker parameter test cases were added:

  1. --security-opt=label=disable --security-opt=no-new-privileges
  2. --security-opt=no-new-privileges
    As the second case causes a Docker 1.12 runc panic in our current
    setup, skip this test when Docker 1.12 is detected.

How to use/test

$ make
$ make test
$ cd bin
$ ./kola run --board=amd64-usr --aws-ami=ami-0c7295725fccdee9b --aws-region=us-west-2 --aws-type=t3.small --aws-iam-profile=jenkins-test --platform=aws --channel=beta --torcx-manifest=torcx_manifest.json --aws-credentials-file ~/.aws/credentials-kola docker.torcx-manifest-pkgs

with this content for the file torcx_manifest.json:

{  "kind": "torcx-package-list-v0",  "value": {    "packages": [      {        "name": "docker",        "versions": [          {            "version": "1.12",            "hash": "sha512-9e96148af25d0b7badb33a70cc03ab7b9a2d6614b840685f605c62dfaae2b0ea2072af4b6c579e5829f1340772ec3b440368a3e0a7cdb34237087559e19566f9",            "casDigest": "9e96148af25d0b7badb33a70cc03ab7b9a2d6614b840685f605c62dfaae2b0ea2072af4b6c579e5829f1340772ec3b440368a3e0a7cdb34237087559e19566f9",            "sourcePackage": "~app-emulation/docker-1.12.6",            "locations": [              {                "path": "/usr/share/torcx/store/docker:1.12.torcx.tgz"              },              {                "url": "http://storage-download.googleapis.com/flatcar-jenkins/torcx/pkgs/amd64-usr/docker/9e96148af25d0b7badb33a70cc03ab7b9a2d6614b840685f605c62dfaae2b0ea2072af4b6c579e5829f1340772ec3b440368a3e0a7cdb34237087559e19566f9/docker:1.12.torcx.tgz"              }            ]          },          {            "version": "18.06",            "hash": "sha512-d3ebae43cfd9f3232a11e4aefb1050a1276d345c51f4cff93ed6cbe686364f54540b1c9300a2cb921c6bd28c5d59010b84ff1b6a8eabbf8972854f1f015afb6b",            "casDigest": "d3ebae43cfd9f3232a11e4aefb1050a1276d345c51f4cff93ed6cbe686364f54540b1c9300a2cb921c6bd28c5d59010b84ff1b6a8eabbf8972854f1f015afb6b",            "sourcePackage": "~app-emulation/docker-18.06.3",            "locations": [              {                "path": "/usr/share/torcx/store/docker:18.06.torcx.tgz"              },              {                "url": "http://storage-download.googleapis.com/flatcar-jenkins/torcx/pkgs/amd64-usr/docker/d3ebae43cfd9f3232a11e4aefb1050a1276d345c51f4cff93ed6cbe686364f54540b1c9300a2cb921c6bd28c5d59010b84ff1b6a8eabbf8972854f1f015afb6b/docker:18.06.torcx.tgz"              }            ]          },          {            "version": "17.03",            "hash": "sha512-5d9dbb7ce20ca519c45f7c0ddd1a08cdc80a5b6ee307e1e5fc365b10af554ea61492afe9c2163f80e05afc6c35164754866d062d1bb62b8cfd57489f948b05fc",            "casDigest": "5d9dbb7ce20ca519c45f7c0ddd1a08cdc80a5b6ee307e1e5fc365b10af554ea61492afe9c2163f80e05afc6c35164754866d062d1bb62b8cfd57489f948b05fc",            "sourcePackage": "~app-emulation/docker-17.03.2",            "locations": [              {                "url": "http://storage-download.googleapis.com/flatcar-jenkins/torcx/pkgs/amd64-usr/docker/5d9dbb7ce20ca519c45f7c0ddd1a08cdc80a5b6ee307e1e5fc365b10af554ea61492afe9c2163f80e05afc6c35164754866d062d1bb62b8cfd57489f948b05fc/docker:17.03.torcx.tgz"              }            ]          }        ],        "defaultVersion": "18.06"      }    ]  }}

Recently two Docker parameter test cases were added:
1. --security-opt=label=disable --security-opt=no-new-privileges
2. --security-opt=no-new-privileges
As the second case causes a Docker 1.12 runc panic in our current
setup, skip this test when Docker 1.12 is detected.
@pothos pothos requested a review from a team May 26, 2020 10:19
@pothos pothos merged commit 145cab0 into flatcar-master May 26, 2020
@pothos pothos deleted the kai/skip-test-case-for-docker-1.12 branch May 26, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant