Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/repo/verify: Keep slashes in branch names #104

Merged
merged 1 commit into from
May 12, 2020

Conversation

pothos
Copy link
Member

@pothos pothos commented May 12, 2020

The branch name was falsely assumed to contain no slashes.
Keep all slashes after the one that separates the origin.
Also filter away local tags which would break the rule that
all after the first slash is a branch name.

How to use

Testing done

The branch name was falsely assumed to contain no slashes.
Keep all slashes after the one that separates the origin.
Also filter away local tags which would break the rule that
all after the first slash is a branch name.
@pothos pothos requested a review from a team May 12, 2020 14:12
Copy link
Contributor

@margamanterola margamanterola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pothos pothos merged commit f4d694f into flatcar-master May 12, 2020
@pothos pothos deleted the kai/cork-verify-branch branch May 12, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants