Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Upgrade Runc in Alpha from 1.0.0_rc90 to 1.0.0_rc91 #463

Closed
wants to merge 2 commits into from
Closed

Upgrade Runc in Alpha from 1.0.0_rc90 to 1.0.0_rc91 #463

wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jul 9, 2020 •
edited by dongsupark
Loading

Upgrade Runc in Alpha from 1.0.0_rc90 to 1.0.0_rc91

@github-actions github-actions bot added the alpha label Jul 9, 2020
@dongsupark dongsupark changed the title Upgrade Runc in Alpha from 1.0.0_rc90 to 1.0.0_rc91 [WIP] Upgrade Runc in Alpha from 1.0.0_rc90 to 1.0.0_rc91 Jul 9, 2020
@dongsupark
Copy link
Contributor

Good news: the commit ID is now correctly generated in the PR.

However, Please do not merge for now.
Build does not pass because of third-party patches that do not apply to runc v1.0.0-rc91.
I was able to fix trivial things, except for the cgroups/systemd patch, which is based on the PR opencontainers/runc#2087. It was created last year, but is still not merged.
Now code around cgroups/systemd has changed so much between rc90 and rc91 that it is not trivial to adapt the patch into rc91.
Let's wait for now.

@dongsupark dongsupark force-pushed the runc-1.0.0_rc91-alpha branch from 5036328 to 91064c4 Compare July 13, 2020 09:04
@dongsupark dongsupark force-pushed the runc-1.0.0_rc91-alpha branch from 91064c4 to 661794c Compare July 21, 2020 16:32
@dongsupark dongsupark changed the title [WIP] Upgrade Runc in Alpha from 1.0.0_rc90 to 1.0.0_rc91 Upgrade Runc in Alpha from 1.0.0_rc90 to 1.0.0_rc91 Jul 21, 2020
@dongsupark
Copy link
Contributor

Build does not pass because of third-party patches that do not apply to runc v1.0.0-rc91.
I was able to fix trivial things, except for the cgroups/systemd patch, which is based on the PR opencontainers/runc#2087. It was created last year, but is still not merged.
Now code around cgroups/systemd has changed so much between rc90 and rc91 that it is not trivial to adapt the patch into rc91.

Sorry, it was wrong. The hybrid cgroup issue affects only Edge, not Alpha.

Pushed other minor build fixes.
So this PR is ready for review.

@dongsupark dongsupark requested a review from a team July 21, 2020 16:34
@pothos pothos changed the base branch from flatcar-master-alpha to main July 23, 2020 15:40
Flatcar Buildbot and others added 2 commits July 29, 2020 17:22
@dongsupark dongsupark force-pushed the runc-1.0.0_rc91-alpha branch from 661794c to 0ddefd0 Compare July 29, 2020 15:22
@dongsupark
Copy link
Contributor

Not needed.
Please see instead #500.

@dongsupark dongsupark closed this Jul 30, 2020
@dongsupark dongsupark deleted the runc-1.0.0_rc91-alpha branch July 30, 2020 08:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dongsupark