Fix arguments of plan
for split QK/VO head dims
#795
Merged
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#765 introduced changes to the API of
plan
, including renaminghead_dim
tohead_dim_qk
and addinghead_dim_vo
. However, some calling sites were not updated to reflect these changes, resulting in failing unit tests.This PR addresses the issue by updating the relevant calls, which should resolve the following unit test failures after merging:
tests/test_block_sparse.py::test_block_sparse_attention
tests/test_non_contiguous_prefill.py::test_batch_paged_prefill_packed_input