-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: add device guard for kernels #611
misc: add device guard for kernels #611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jeejeelee , thanks for bringing this up, would you mind adding device guard for JIT templates as well?
- https://github.com/flashinfer-ai/flashinfer/blob/a3360ff9c85e7d0bae8bb4ca6dbbca69cfadea37/python/flashinfer/jit/batch_decode_mla_templ.py
- https://github.com/flashinfer-ai/flashinfer/blob/a3360ff9c85e7d0bae8bb4ca6dbbca69cfadea37/python/flashinfer/jit/batch_decode_templ.py
- https://github.com/flashinfer-ai/flashinfer/blob/a3360ff9c85e7d0bae8bb4ca6dbbca69cfadea37/python/flashinfer/jit/batch_prefill_templ.py
- https://github.com/flashinfer-ai/flashinfer/blob/a3360ff9c85e7d0bae8bb4ca6dbbca69cfadea37/python/flashinfer/jit/single_decode_templ.py
- https://github.com/flashinfer-ai/flashinfer/blob/a3360ff9c85e7d0bae8bb4ca6dbbca69cfadea37/python/flashinfer/jit/single_prefill_templ.py
@yzh119 I have checked all kernels and added the device guards. Additionally, I tested the ROPE and NORM kernel in a CUDA 11.8 environment to verify they pass the tests. Please let me know if any additional testing is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, thanks for the fix @jeejeelee !
plan
FIX: #452