Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add device guard for kernels #611

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

jeejeelee
Copy link
Contributor

@jeejeelee jeejeelee commented Nov 15, 2024

plan

  • Check all kernels and add device guard
  • Complete the tests

FIX: #452

@jeejeelee jeejeelee marked this pull request as draft November 15, 2024 17:07
@jeejeelee
Copy link
Contributor Author

@yzh119 I have checked all kernels and added the device guards. Additionally, I tested the ROPE and NORM kernel in a CUDA 11.8 environment to verify they pass the tests. Please let me know if any additional testing is needed.

@yzh119 yzh119 marked this pull request as ready for review November 15, 2024 19:05
Copy link
Collaborator

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, thanks for the fix @jeejeelee !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SingleDecodeWithKVCache meets illegal memory access when setting input tensors to cuda:1
2 participants