Feature/non contiguous kv cache #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yzh119 Please review 👀 |
|
Hi @LinHeLurking , I'm finalizing #507 (there are still some work to be done to keep both AOT and JIT #510 ) and I'll start working on rebasing your PR as soon as possible. Thanks for your contribution and patience! |
Signed-off-by: LinHeLurking <[email protected]>
Signed-off-by: LinHeLurking <[email protected]>
yzh119
force-pushed
the
feature/non-contiguous-kv-cache
branch
from
0ca5ec6 to
f8d7129
Compare
yzh119
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
@LinHeLurking Thanks so much for your contribution, this is indeed a very important feature to have, I rebased your code into the main branch to make it compatible with the codebase after JIT support.
I also made the following changes to make the code simpler:
- Do not pass
paged_kv_cache,paged_k_cache,paged_v_cacheto C++ APIs, we just keeppaged_k_cache,paged_v_cachein C++ API, if user provide a single paged_kv_cache, we split it at python-side.
cc @reyoung for visibility.
yzh119
added a commit
that referenced
this pull request
Oct 11, 2024
We introduced a bug in #513 because we didn't consider non-contiguous kv-cache for page append operator, this PR fix the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #506
Custom strides to support non-contiguous kv cache.
Tests in
test_batch_prefill_kernels.pyandtest_batch_decode_kernels.pyare modified to test input kv_data on both contiguous and non-contiguous tensor.