Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1545 merge scrapers topology logging into connectors page #1557

Merged
merged 6 commits into from
Mar 22, 2024
Merged

1545 merge scrapers topology logging into connectors page #1557

merged 6 commits into from
Mar 22, 2024

Conversation

mainawycliffe
Copy link
Contributor

@mainawycliffe mainawycliffe commented Dec 13, 2023 •
edited
Loading

Closes #1546
Closes #1583
Closes #1636
Closes #1635
Closes #1371

@netlify Netlify
Copy link

netlify bot commented Dec 13, 2023 •
edited
Loading

✅ Deploy Preview for goofy-euclid-75956c ready!

Name Link
🔨 Latest commit 722b4a8
🔍 Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/65fd2c0c12fb250008ee7fec
😎 Deploy Preview https://deploy-preview-1557--goofy-euclid-75956c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 13, 2023 •
edited
Loading

✅ Deploy Preview for flanksource-demo-stable ready!

Name Link
🔨 Latest commit 722b4a8
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/65fd2c0cffba9e0008cec429
😎 Deploy Preview https://deploy-preview-1557--flanksource-demo-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch from ecd039c to 3529c06 Compare December 13, 2023 06:04
@netlify Netlify
Copy link

netlify bot commented Dec 13, 2023 •
edited
Loading

✅ Deploy Preview for clerk-saas-ui ready!

Name Link
🔨 Latest commit 722b4a8
🔍 Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/65fd2c0c19580f0008ba13a8
😎 Deploy Preview https://deploy-preview-1557--clerk-saas-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch 8 times, most recently from 5177a59 to 9b781bf Compare December 19, 2023 08:18
@mainawycliffe mainawycliffe marked this pull request as ready for review December 19, 2023 08:19
@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch from 9b781bf to 5a400be Compare December 20, 2023 15:08
@moshloop moshloop force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch from 5a400be to 1fd94b3 Compare December 22, 2023 07:31
@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch 4 times, most recently from ac54c9d to ae58fe8 Compare January 4, 2024 06:01
@moshloop
Copy link
Member

moshloop commented Jan 4, 2024 •
edited by mainawycliffe
Loading

  • - Default to Flux instead of CLI
  • - Page title should be Integrations
  • - Clicking on a row does not edit
  • - Rename Save for the Helm/Flux installs to Close

Mission Control

  • - Failed to load spec file errror
  • Kubernetes
  • - don't include upstream section
  • - make the interval customizable with a default of 30m (split out)
  • - The name label should be "Cluster Name" and map to scraper.clusterName
  • - Namespace should be customizable and default to mission-control (split out)
  • - HelmRelease seems duplicated
  • - Add a new parameter called "Prometheus URL" with hint, "The URL of the prometheus server to use when collecting metrics", mapped to prometheusURL

AWS

  • - chart is missing
  • - Need to add regions

Prometheus

  • - Required parameter URL is missing

Custom Catalog

  • - Modal title should reflect current path (split out)

  • - Error when saving

  • - Log Backends should be hidden when logs.disable=true (split out)

@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch from ae58fe8 to 3540da2 Compare January 10, 2024 10:33
@mainawycliffe mainawycliffe marked this pull request as draft January 10, 2024 10:33
This was referenced Jan 18, 2024
Closed
Open
Closed
Closed
@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch 4 times, most recently from 3732ff6 to c913d8e Compare January 19, 2024 18:05
@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch from 0e23196 to b672f80 Compare February 25, 2024 21:24
@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch from b672f80 to adf33b9 Compare February 27, 2024 14:40
@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch from adf33b9 to 5be14c5 Compare March 4, 2024 06:27
@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch from 5be14c5 to dbc3043 Compare March 4, 2024 15:20
@moshloop
Copy link
Member

moshloop commented Mar 4, 2024 •
edited by mainawycliffe
Loading

@mainawycliffe

  • We still seem to be duplicating helm releases
  • The topology names should default
  • The dialog title does not reset, after selecting an integration
  • Expand the row groups by default
  • Clicking on a status does not show the history
  • The status format is not consistent with job history table
  • The styling and layout of helm/flux should match the agent page

@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch from dbc3043 to b58d867 Compare March 6, 2024 07:57
@mainawycliffe mainawycliffe marked this pull request as draft March 19, 2024 07:28
@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch from b58d867 to 48cf3ae Compare March 19, 2024 07:29
@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch from 48cf3ae to 3ab3f54 Compare March 21, 2024 19:43
@mainawycliffe mainawycliffe marked this pull request as ready for review March 21, 2024 19:46
@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch from 3ab3f54 to cdc54f4 Compare March 22, 2024 06:32
@mainawycliffe
fix: move flux to first tab for agents installation instruction
7b16a55 
fix: redirect only configs
@mainawycliffe
chore: use node 20 at netlify
62e7a61
@mainawycliffe
refactor: use event to set doclink to useEffect
a54a7fb
@mainawycliffe
chore: add links to the docs for config scrappers
9337b37
@mainawycliffe
refactor: change how useUpdateResource works
7d70ea9
@mainawycliffe
feat: create an add integrations wizard for the UI
722b4a8 
Closes #1546

feat: create an integrations page

Closes #1545

feat: add integration form options

Closes #1546

fix: fix failing builds

fix: fix build issues

chore: rename integration view

fix: add method to save catalog scrapper

fix: add helm and flux tabs

fix: organize imports

feat: improve integrated page

fix: convert failed

fix: fix table not showing some columns

fix: remove duplicate back button footer

feat: add icons

fix: fix failing builds

fix: fix padding issue

fix: make improvements to add integration

fix: fix issues

feat: add edit integration UI

refactor: remove editor for topology and catalog scrapper

fix: fix issue to re-mapping of key-value map

fix: fix a few issues

fix: fix issue with delete redirects

fix: add back button to topology template options

fix: fix issue for catalog scrapper not saving

fix: fix issue with wizard

fix: fix padding issue

fix: fix undefined within yaml template

chore: refactor and improve form

fix: fix data mapping in flux and kubernetes

fix: source should default to UI

chore: remove topology name placeholder

chore: restore source and make readonly

feat: group by integration type

fix: remove duplicate namespace field

fix: restore topology, config scrappers and log backends

fix: issues related to the integrations pages

fix: add add integration to all sub menus and hide integrations page

fix: make improvements to the add integration wizard

fix: fix build

fix: fix a few minor issues
@mainawycliffe mainawycliffe force-pushed the 1545-merge-scrapers-topology-logging-into-connectors-page branch from cdc54f4 to 722b4a8 Compare March 22, 2024 06:58
@moshloop moshloop merged commit 5a6aece into main Mar 22, 2024
13 of 15 checks passed
@moshloop moshloop deleted the 1545-merge-scrapers-topology-logging-into-connectors-page branch March 22, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mainawycliffe @moshloop