chore: os.Exit(1) on log.fatal · flanksource/commons@940cba2

Triggered via pull request August 22, 2024 06:09

opened #169

exit-fatal

Status Failure

Total duration 3m 57s

Artifacts –

lint.yml

on: pull_request

7 errors and 1 warning

lint: properties/properties.go#L193

Error return value of `p.LoadFile` is not checked (errcheck)

lint: logger/slog.go#L210

printf: non-constant format string in call to (github.com/flanksource/commons/logger.SlogLogger).Debugf (govet)

lint: logger/slog.go#L245

printf: non-constant format string in call to github.com/flanksource/commons/logger.BrightF (govet)

lint: net/net.go#L42

printf: non-constant format string in call to fmt.Errorf (govet)

lint: net/net.go#L56

printf: non-constant format string in call to fmt.Errorf (govet)

lint: console/test_results.go#L140

printf: non-constant format string in call to (*github.com/flanksource/commons/console.TestResults).Passf (govet)

issues found

The following actions use a deprecated Node.js version and will be forced to run on node20: golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/