perf: AnyOfFilter shouldn't impose distinct by default unless joini…

…ng on another table

drf_kit/filters.py

@@ -93,6 +93,10 @@ def clean(self, value):
 class AnyOfFilter(MultipleChoiceFilter):
     field_class = _OpenChoiceField
 
+    def __init__(self, *args, **kwargs):
+        kwargs.setdefault("distinct", None)
+        super().__init__(*args, **kwargs)
+
     def filter(self, qs, value):
         if not value:
             return qs
@@ -105,7 +109,10 @@ def filter(self, qs, value):
             query_filter = Q(**predicate)
             qs = self.get_method(qs)(query_filter)
 
-        return qs.distinct() if self.distinct else qs
+        possibly_filtering_on_relationship = "__" in self.field_name
+        force_distinct = possibly_filtering_on_relationship if self.distinct is None else self.distinct
+
+        return qs.distinct() if force_distinct else qs
 
 
 class AllOfFilter(MultipleChoiceFilter):

test_app/filters.py

@@ -25,6 +25,7 @@ class Meta:
 
 class WizardFilterSet(filters.BaseFilterSet):
     spell_name = filters.AllOfFilter(field_name="spell_casts__spell__name")
+    any_spell_name = filters.AnyOfFilter(field_name="spell_casts__spell__name")
 
     class Meta:
         model = models.Wizard

test_app/tests/tests_views/tests_filter_views.py

@@ -138,6 +138,10 @@ def test_filter_multiple_spell_name_conjoined_return_wizards(self):
         response = self.client.get(self.url, data={"spell_name": [self.spell_a.name, self.spell_b.name]})
         self.assertResponseItems(expected_items=[self.wizard_a], response=response)
 
+    def test_filter_multiple_spell_name_any_of_through_relationship(self):
+        response = self.client.get(self.url, data={"any_spell_name": [self.spell_a.name, self.spell_b.name]})
+        self.assertResponseItems(expected_items=[self.wizard_a, self.wizard_b], response=response)
+
     def test_filter_multiple_spell_name_disjointed_not_return_wizards(self):
         response = self.client.get(self.url, data={"spell_name": [self.spell_a.name, self.spell_noise.name]})
         self.assertResponseItems(expected_items=[], response=response)