Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dagbladet #695

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Update Dagbladet #695

merged 1 commit into from
Feb 4, 2025

Conversation

addie9800
Copy link
Collaborator

Apologies for this PR, it's a bit messy, but unfortunately, Dagbladet decided to keep its old layout on some of the subpages like https://borsen.dagbladet.no/nyheter/tror-kina-kan-velge-tesla-hevn/82617028. Another issue we should discuss is in this article: https://www.dagbladet.no/nyheter/bolgneset-utbygging-legges-pa-is/82591507. They have the normal summary, as always, and an AI-generated one. I would argue that we should also extract the summary; where I am unsure is whether or not to include the AI disclaimer in the plaintext. I left it in for now, but I would also agree to remove it.

@addie9800 addie9800 requested a review from MaxDall February 2, 2025 15:41
Copy link
Collaborator

@MaxDall MaxDall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@addie9800 Thanks for fixing this! LGTM.

@MaxDall MaxDall merged commit f5bd324 into master Feb 4, 2025
5 checks passed
@MaxDall MaxDall deleted the fix-dagbladet branch February 4, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants