Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NikkanGeadai #689

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Add NikkanGeadai #689

merged 4 commits into from
Feb 3, 2025

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Jan 22, 2025

This PR also adds a new utility function to transform <br> into <p> elements. Maybe @addie9800 wants to give it a shot for TheNamibian and also TimesOfIndia.

@MaxDall MaxDall requested a review from addie9800 January 22, 2025 13:49
@MaxDall MaxDall changed the base branch from master to add-sankei-shimbun January 22, 2025 13:49
Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition 👍

Base automatically changed from add-sankei-shimbun to master January 31, 2025 12:34
@MaxDall MaxDall requested a review from addie9800 January 31, 2025 12:43
@MaxDall MaxDall merged commit 7c5d78c into master Feb 3, 2025
5 checks passed
@MaxDall MaxDall deleted the add-pr-times branch February 3, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants