Add SankeiShimbun
#688
Merged
Add SankeiShimbun
#688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addie9800
requested changes
Jan 23, 2025
|
|
||
| @attribute | ||
| def topics(self) -> List[str]: | ||
| return generic_topic_parsing(self.precomputed.meta.get("news_keywords")) |
There was a problem hiding this comment.
I think I would not use the news_keywords, since it seems to be as if all articles habe the same generic topics:
['Sankei Shimbun', 'Sankei', 'Sankei', 'Newspaper', 'News', 'Breaking news', 'Politics', 'Economy', 'Society', 'International', 'Sports', 'Entertainment'].
Instead the section lists seems to be more relevant: //*[@id="main-column"]/main/article/div[1]/div/div[2]/div[1]/ul or the tag labels at the bottom of the article //*[@id="main-column"]/main/article/div[11]/div/div[1]
addie9800
previously approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.