Fix trailing whitespace issue #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@addie9800 Wow, thanks a lot! Especially for the in-depth explanation. That's an awesome fix 🚀 |
MaxDall
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to reproduce the issue causing pytest to fail on GitHub. It's failing due to an update that was released for
xmttodict(installing xmltodict 0.14.1 reproduces the error, while no errors are raised with 0.13.0), although that is not the reason for the errors. What changed with the update is that the values were not stripped anymore causing the assertion errors.That leads to the question, why stripping was necessary in the first place. Turns out, they are introduced by including the tail of a node into string representation of the node. Since the tail only includes the content between the closing tag of that node and the starting tag of the next node, I think it can be safely removed.