Add default return values for attributes #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addie9800
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a long-lasting bug when using
suppressas error handling, disabling its functionality. Because of the lack of default values forAttributes, whenever an error occurred during the parsing of a specific attribute the exception was passed to the scraper, skipping the entire article.This PR adds a property
__default__to the attribute. The property returns a default value for the specific attribute based on its annotation, thus enabling us to use default values in case of an exception.Further, I changed the type of
bodyin the guidelines toOptional[ArticleBody]to be more in tune withArticle.The only review-relevant file here is
base_parser.py