Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate get_value_by_key_path and replace with xpath_search #626

Merged
merged 8 commits into from
Oct 13, 2024
Merged

Deprecate get_value_by_key_path and replace with xpath_search #626

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
930fc3d
deprecate `get_value_by_key_path`
MaxDall Oct 3, 2024
0446ba2
throw pytest error with warnings
MaxDall Oct 3, 2024
495fce7
allow str as query and add `scalar` parameter to `xpath_search`
MaxDall Oct 3, 2024
bc039d4
replace occasions of `get_value_by_key_path` with `xpath_search`
MaxDall Oct 3, 2024
f8c2183
fix typing
MaxDall Oct 3, 2024
cf93360
fix escape sequence for `VerdensGang` sitemap filter
MaxDall Oct 3, 2024
a531862
fix documentation and type hint for `xpath_search`
MaxDall Oct 8, 2024
da7fe93
remove `scalar=True`
MaxDall Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove scalar=True
  • Loading branch information
@MaxDall
MaxDall committed Oct 8, 2024
commit da7fe932f644561dba22c7c5cc6c60e3f542d49a
2 changes: 1 addition & 1 deletion src/fundus/publishers/shared/euronews.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def body(self) -> ArticleBody:

@attribute
def authors(self) -> List[str]:
author_string = self.precomputed.ld.xpath_search("NewsArticle/author/name", scalar=True)
author_string = self.precomputed.ld.xpath_search("NewsArticle/author/name")
return utility.generic_author_parsing(author_string)

@attribute
Expand Down