Cleaner code for LD and JSON parsing #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addie9800
approved these changes
Oct 3, 2024
| return None | ||
|
|
||
| # substitute "bad" values | ||
| sanitized = re.sub(_json_undefined, r"\g<key>:null", sanitized) |
There was a problem hiding this comment.
This is possible? 🤯 You don't want to know how often I worked around that to avoid selecting text I don't want to loose due to substitution...
There was a problem hiding this comment.
I feel you 😄 regex is a rabbit hole and every time I have to use it I find myself half an hour and 30 open tabs later scratching my head.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make the code about LD and JSON parsing a bit less complex. Further, I removed some unused imports for
TheNamibian