Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swiss newspaper Tages Anzeiger #608

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Add Swiss newspaper Tages Anzeiger #608

merged 3 commits into from
Sep 13, 2024

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Sep 4, 2024

No description provided.

@MaxDall MaxDall requested a review from addie9800 September 4, 2024 13:18
Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this new publisher. I only got a minor comment :)

class V1(BaseParser):
_summary_selector = CSSSelector("p.ContentHead_lead____SsS")
_subheadline_selector = CSSSelector("article > h2")
_paragraph_selector = CSSSelector("article > p:not(.ContentHead_lead____SsS):not(.Feedback_root__fr_Mi)")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also filter out p elements with class ArticleContainer_agencies__g6Lpj ArticleContainer_content-width__FRl7F. They contain the contributing agencies at the end of an article, like SDA/ij in this article

@MaxDall MaxDall requested a review from addie9800 September 13, 2024 11:31
@MaxDall MaxDall merged commit 1bb4140 into master Sep 13, 2024
5 checks passed
@MaxDall MaxDall deleted the add-tages-anzeiger branch September 13, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants