Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release workflow to automatically publish on PyPi #358

Merged
merged 8 commits into from
Mar 26, 2024

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Feb 15, 2024

This workflow adds the following jobs that trigger on any release with type released.

Jobs:

  1. Test/Lint using existing workflows
  2. Build distribution
  3. Upload to TestPyPi
  4. Test installation from TestPyPi
  5. Upload to PyPi

@MaxDall MaxDall added the feature Have an idea on how to improve the code base? Come forward and let us know. label Feb 15, 2024
@MaxDall MaxDall requested a review from dobbersc February 15, 2024 21:14
@MaxDall
Copy link
Collaborator Author

MaxDall commented Mar 26, 2024

I tested the action on a separate public test repository I created. You can find the corresponding run here

@MaxDall MaxDall requested a review from addie9800 March 26, 2024 13:37
Copy link
Collaborator

@dobbersc dobbersc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really useful! I have just some minor comments / questions.

path: dist/
- name: Publish distribution 📦 to PyPI
uses: pypa/gh-action-pypi-publish@release/v1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also a lot of deprecation notices on the test run. But fixing them would be for another PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I also noticed them but wasn't motivated enough to check if a simple version bump for all actions would solve the problem or if it's on the runners side.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets just see how it is in future runs in the main repository and try a version bump later. Maybe open an issue for that?

dobbersc
dobbersc previously approved these changes Mar 26, 2024
@MaxDall MaxDall merged commit 76dd470 into master Mar 26, 2024
4 checks passed
@MaxDall MaxDall deleted the pypi-release-workflow branch March 26, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Have an idea on how to improve the code base? Come forward and let us know.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants