-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release workflow to automatically publish on PyPi #358
Conversation
I tested the action on a separate public test repository I created. You can find the corresponding run here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really useful! I have just some minor comments / questions.
path: dist/ | ||
- name: Publish distribution 📦 to PyPI | ||
uses: pypa/gh-action-pypi-publish@release/v1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also a lot of deprecation notices on the test run. But fixing them would be for another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I also noticed them but wasn't motivated enough to check if a simple version bump for all actions would solve the problem or if it's on the runners side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets just see how it is in future runs in the main repository and try a version bump later. Maybe open an issue for that?
Co-authored-by: Conrad Dobberstein <[email protected]>
This workflow adds the following jobs that trigger on any release with type
released
.Jobs: