Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Business Insider #341

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Add Business Insider #341

merged 2 commits into from
Feb 6, 2024

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Jan 29, 2024

Adds Business Insider as a publisher.

@MaxDall MaxDall changed the title add Business Insider Add Business Insider Jan 29, 2024
Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this

@MaxDall
Copy link
Collaborator Author

MaxDall commented Jan 31, 2024

Oh wow, awesome 👍 Thanks for this really in depth review. Especially the link's to all the edge cases helping a lot. How did you find them?

@addie9800
Copy link
Collaborator

No problem. I crawled 50 articles and printed the title, authors, plaintext, url and topics. I then skimmed over the output and then I can check out the articles everytime something seems weird.

Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@MaxDall MaxDall merged commit c18f234 into master Feb 6, 2024
5 checks passed
@MaxDall MaxDall deleted the add-business-insider branch February 6, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants