use transformers sentencepiece requirement #2835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2833
As flair doesn't use sentencepiece itself, but lets transformers use it indirectly, I propose to let the transformers package handle that dependency.
This has two advantages:
a) we can use a more broad range of sentencepiece versions
b) if there are any new versions that break something, the transformers guys will handle it
Note: relies on #2827 to be merged first for passing tests