Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use transformers sentencepiece requirement #2835

Merged

Conversation

helpmefindaname
Copy link
Member

@helpmefindaname helpmefindaname commented Jun 24, 2022

fixes #2833

As flair doesn't use sentencepiece itself, but lets transformers use it indirectly, I propose to let the transformers package handle that dependency.
This has two advantages:
a) we can use a more broad range of sentencepiece versions
b) if there are any new versions that break something, the transformers guys will handle it

Note: relies on #2827 to be merged first for passing tests

@whoisjones
Copy link
Member

👍

@alanakbik
Copy link
Collaborator

Makes a lot of sense, thanks @helpmefindaname!

@alanakbik alanakbik merged commit 7d8b188 into flairNLP:master Jun 29, 2022
@helpmefindaname helpmefindaname deleted the bf/sentencepiece-dependency branch June 29, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to update sentencepiece requirement to 0.1.96
3 participants