Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity linking #2375

Merged
merged 10 commits into from
Aug 18, 2021
Merged

Entity linking #2375

merged 10 commits into from
Aug 18, 2021

Conversation

marcelmmm
Copy link
Collaborator

EntityLinker and Entity Linking Datasets

@alanakbik
Copy link
Collaborator

I think the dependency 'wikipediaapi' needs to be added to requirements.txt

@alanakbik
Copy link
Collaborator

I've added the missing requirements and also changed the default sentence splitters to Sektok since SpaCy requires additional modules to be installed that don't come with default Flair. In the AQUAINT_EL and IITB_EL corpora, you can now pass the sentence_splitter as an argument in case you want to use SpaCy instead.

However, unfortunately the change to SegTok broke AQUAINT_EL since it now sometimes splits a sentence at the wrong place and breaks up an entity. You can reproduce this error with:

corpus = AQUAINT_EL()

Could you take a look?

@marcelmmm
Copy link
Collaborator Author

Thank you for all this!!
I changed the AQUAINT_EL corpus. Now it works when using SegTok as well.

@alanakbik
Copy link
Collaborator

@marcelmmm thanks a lot for adding this!

@alanakbik alanakbik merged commit c1e30fa into master Aug 18, 2021
@alanakbik alanakbik deleted the EntityLinking branch August 22, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants