-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-177: Update tests #183
GH-177: Update tests #183
Conversation
|
||
|
||
@pytest.mark.slow | ||
def test_train_load_use_classifier(results_base_path, tasks_base_path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the integration tests really need to be skipped on travis? They only make small models and are important for catching lots of errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps remove @pytest.mark.slow from the integration tests? Its good to skip the tests for loading all the models and embeddings (i.e. test_embeddings.py) since they are too big, but the training, loading and saving steps should be tested in different variations since they caused lots of errors in the last release.
dc655d5
to
a576b49
Compare
Update: Travis runs unit and integration test on a pull request. On a normal push just the unit tests are executed. Slow tests (such as To run only unit tests: |
Great work, thanks! |
TRAVIS
envpytest
pytest --runslow
closes #177