GH-151: Reset cache settings when saving model #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanakbik
reviewed
Oct 18, 2018
| @@ -460,8 +462,11 @@ def embedding_length(self) -> int: | |||
|
|
|||
| def _add_embeddings_internal(self, sentences: List[Sentence]) -> List[Sentence]: | |||
|
|
|||
| cache_path = '{}-tmp-cache.sqllite'.format(self.name) if self.cache_directory is None else os.path.join( | |||
| self.cache_directory, '{}-tmp-cache.sqllite'.format(os.path.basename(self.name))) | |||
There was a problem hiding this comment.
This fails if self.cache_directory is not set.
There was a problem hiding this comment.
It should not as self.cache_directory is set to None by default and we are checking in this line if self.cache_directory is None or not.
tabergma
force-pushed
the
GH-151-use-cache
branch
from
a4db653 to
6ebbc99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #151