Make load_big_file work with read-only file #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "rb" rather than "r+b" and specify access=mmap.ACCESS_READ
jjjamie
commented
Jan 14, 2020
| @@ -22,16 +22,16 @@ | |||
| logger = logging.getLogger("flair") | |||
|
|
|||
|
|
|||
| def load_big_file(f): | |||
| def load_big_file(f: str) -> mmap.mmap: | |||
There was a problem hiding this comment.
And some type annotations!
|
It must be made as an option. Models are also loaded for further training. |
|
@alanakbik Ok, you are right! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "rb" rather than "r+b" and specify access=mmap.ACCESS_READ
I would like to be able to read model files on a read-only share but current code crashes with permissions problems - this fixes for me