GH-1073: batch first #1077
Merged
GH-1073: batch first #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1073
This PR changes
WordDropoutandLockedDropoutto be robust tobatch_firstmode. ForLockedDropoutthis means adding a boolean parameterbatch_firstto the constructor that by default is set toTrue.The
WordDropoutis now implemented differently as the previous version was a 'lcoked' word dropout that would always drop the same index words across a mini-batch. Now, words are dropped fully at random. Some initial experiments show that this improves downstream task training.The PR also removes the transpose operations in the
SequenceTaggerand theDocumentRNNEmbeddingsand removes the sorting logic from theDocumentRNNEmbeddings.