Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming conventions for interfaces and classes #12

Closed
alanakbik opened this issue Jul 27, 2018 · 1 comment
Closed

Naming conventions for interfaces and classes #12

alanakbik opened this issue Jul 27, 2018 · 1 comment

Comments

@alanakbik
Copy link
Collaborator

Clarify naming of classes and interfaces:

  • Embedding classes TokenEmbeddings vs DocumentEmbeddings
  • trainer classes
  • module imports
alanakbik pushed a commit that referenced this issue Jul 27, 2018
GH-12: naming conventions for files and embeddings
614e32f
alanakbik pushed a commit that referenced this issue Jul 27, 2018
GH-12: updated tutorials with new class names
5ac6a3b
This was referenced Jul 27, 2018
Closed
Merged
alanakbik pushed a commit that referenced this issue Jul 27, 2018
GH-12: removed commented out code + gitignore spam
e5bbce0
tabergma added a commit that referenced this issue Jul 27, 2018
@tabergma
Merge pull request #14 from zalandoresearch/GH-12-naming-conventions
4dc654d 
Gh 12 naming conventions
@alanakbik
Copy link
Collaborator Author

done!

tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: naming conventions for files and embeddings
3cf4cfd
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: updated tutorials with new class names
2b72a3d
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: removed commented out code + gitignore spam
e9ab8bf
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: naming conventions for files and embeddings
9e3c0e4
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: updated tutorials with new class names
97addcc
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: removed commented out code + gitignore spam
e95581e
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: naming conventions for files and embeddings
f4de641
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: updated tutorials with new class names
54ef075
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: removed commented out code + gitignore spam
4b80ba7
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: naming conventions for files and embeddings
8a743f2
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: updated tutorials with new class names
0e84bb3
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: removed commented out code + gitignore spam
9ad5baa
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: naming conventions for files and embeddings
0250fc0
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: updated tutorials with new class names
4d5cb79
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: removed commented out code + gitignore spam
3ae403c
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: naming conventions for files and embeddings
0076492
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: updated tutorials with new class names
45c8946
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: removed commented out code + gitignore spam
b257f4d
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: naming conventions for files and embeddings
c83610d
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: updated tutorials with new class names
f8f0397
tabergma pushed a commit that referenced this issue Jul 31, 2018
@tabergma
GH-12: removed commented out code + gitignore spam
2ad6706
tabergma pushed a commit that referenced this issue Aug 2, 2018
@tabergma
GH-12: updated tutorials with new class names
a6bd0af
tabergma pushed a commit that referenced this issue Aug 2, 2018
@tabergma
GH-12: updated tutorials with new class names
9c8dff7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tabergma @alanakbik