GH-19: fixed error in updating Metric

flairNLP · Jul 31, 2018 · 5ca22d6 · 5ca22d6
1 parent 7ffcafd
commit 5ca22d6
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/flair/data_fetcher.py b/flair/data_fetcher.py
@@ -288,7 +288,7 @@ def read_conll_ud(path_to_conll_file: str) -> List[Sentence]:
                     if not "=" in morph: continue;
                     token.add_tag(morph.split('=')[0].lower(), morph.split('=')[1])
 
-                if str(fields[10]) == 'Y':
+                if len(fields) > 10 and str(fields[10]) == 'Y':
                     token.add_tag('frame', str(fields[11]))
 
                 sentence.add_token(token)

diff --git a/flair/trainers/sequence_tagger_trainer.py b/flair/trainers/sequence_tagger_trainer.py
@@ -192,6 +192,24 @@ def evaluate(self, evaluation: List[Sentence], out_path=None, evaluation_method:
                     else:
                         fp += 1
 
+                    # positives
+                    if predicted_tag != '':
+                        # true positives
+                        if predicted_tag == gold_tag:
+                            metric.tp()
+                        # false positive
+                        if predicted_tag != gold_tag:
+                            metric.fp()
+
+                    # negatives
+                    if predicted_tag == '':
+                        # true negative
+                        if predicted_tag == gold_tag:
+                            metric.tn()
+                        # false negative
+                        if predicted_tag != gold_tag:
+                            metric.fn()
+
                     lines.append(eval_line)
 
                 lines.append('\n')