Skip to content

Commit

Permalink
Merge pull request #25 from flagship-io/feature_FS3-682
Browse files Browse the repository at this point in the history
fix goroutine leak activation
  • Loading branch information
kjose authored Oct 26, 2022
2 parents 3abd664 + a293235 commit 66206bd
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions pkg/handlers/activate.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,17 +100,18 @@ func Activate(context *connectors.DecisionContext) func(http.ResponseWriter, *ht
if shouldPersistActivation {
errorsLength++
go func(activateItem *activate_request.ActivateRequest) {
if !context.AssignmentsManager.ShouldSaveAssignments(connectors.SaveAssignmentsContext{
var err error = nil
if context.AssignmentsManager.ShouldSaveAssignments(connectors.SaveAssignmentsContext{
AssignmentScope: connectors.Activation,
}) {
return
err = context.AssignmentsManager.SaveAssignments(context.EnvID, activateItem.Vid, map[string]*decision.VisitorCache{
activateItem.Caid: {
VariationID: activateItem.Vaid,
Activated: true,
},
}, now)
}
errors <- context.AssignmentsManager.SaveAssignments(context.EnvID, activateItem.Vid, map[string]*decision.VisitorCache{
activateItem.Caid: {
VariationID: activateItem.Vaid,
Activated: true,
},
}, now)
errors <- err
}(activateItem)
}

Expand Down

0 comments on commit 66206bd

Please sign in to comment.