Fix for 'MixedContent' error in browser when running behind HTTPS proxy #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what about the same code in lines 106 and 114 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using sinopia behind a HTTPS proxy (e.g. with rnbwd/sinopia) CSS, favicon and other resources are loaded from the HTTP URL. This causes a MixedContent error in most modern browsers, preventing i.e. the CSS file to be loaded.
This pull request removes setting the 'base' URL explicitly, because 'req.protocol' contains 'HTTP' when a HTTPS proxy is forwarding the request. Leaving the 'base' URL empty makes the browser choose the correct protocol automatically.