Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in parsing empty inputs #471

Merged
merged 4 commits into from
Jan 25, 2025
Merged

Fix error in parsing empty inputs #471

merged 4 commits into from
Jan 25, 2025

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Jan 22, 2025

This bug was introduced in the previous PR #470 and this PR fixes it by adding a check of the size read from an input stream.
Several test cases for a variety of empty inputs have also been added so a similar bug can be found before merging changes in the future.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Jan 22, 2025
@fktn-k fktn-k added this to the Release v0.4.2 milestone Jan 22, 2025
@fktn-k fktn-k self-assigned this Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 03b5230f3d683bbb5d1b5baa6de607eda35d9df8.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr471.zip
ID 2469557165
URL https://github.com/fktn-k/fkYAML/actions/runs/12913510309/artifacts/2469557165

@fktn-k fktn-k changed the title Fix segfault while reading empty input stream Fix error in parsing empty inputs Jan 22, 2025
@fktn-k fktn-k merged commit 32c7d1a into develop Jan 25, 2025
163 checks passed
@fktn-k fktn-k deleted the fix_parse_empty_input branch January 25, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant