Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit an error if ":" is missing after a mapping key #450

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Dec 22, 2024

This PR adds checks to detect errors when the ":" mapping value indicator is not followed after a mapping key.
As reported in the issue #449, the current implementation cannot detect such an invalid syntax and even generate a wrong deserialization result.
Also, the deserializer has also been fixed to properly handle empty mapping values, which was turned out to be an underlying issue of the above one.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Dec 22, 2024
@fktn-k fktn-k added this to the Release v0.4.1 milestone Dec 22, 2024
@fktn-k fktn-k self-assigned this Dec 22, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 8136f3fd36a955448e808a9c17fb521d173a548d.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr450.zip
ID 2353579788
URL https://github.com/fktn-k/fkYAML/actions/runs/12455647734/artifacts/2353579788

@fktn-k fktn-k changed the title Bugfix/449 check map val indicator after key Emit an error if ":" is missing after a mapping key Dec 22, 2024
@fktn-k fktn-k merged commit 7d9e702 into develop Dec 23, 2024
163 checks passed
@fktn-k fktn-k deleted the bugfix/449_check_map_val_indicator_after_key branch December 23, 2024 02:31
@fktn-k fktn-k mentioned this pull request Dec 23, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant