Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intoduces
FK_YAML_LIKELY
andFK_YAML_UNLIKELY
macros which conditionally expand to:[[likely]]
and[[unlikely]]
C++ attributes if available (preferred since they should be compiler agnostic as part of C++ standard attributes)__builtin_expect(!!(expr), 1)
and__builtin_expect(!!(expr), 0)
invocations if__builtin_expect
is available (like GCC like compilers)!!(expr)
if the above two aren't available (like MSVC compilers with C++11-17)Along with the above change, some preprocessor macros have also been tidied.
Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdef
s or other means.