Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use likely/unlikely if available #395

Merged
merged 3 commits into from
Sep 21, 2024
Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Sep 21, 2024

This PR intoduces FK_YAML_LIKELY and FK_YAML_UNLIKELY macros which conditionally expand to:

  • [[likely]] and [[unlikely]] C++ attributes if available (preferred since they should be compiler agnostic as part of C++ standard attributes)
  • __builtin_expect(!!(expr), 1) and __builtin_expect(!!(expr), 0) invocations if __builtin_expect is available (like GCC like compilers)
  • just !!(expr) if the above two aren't available (like MSVC compilers with C++11-17)

Along with the above change, some preprocessor macros have also been tidied.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label Sep 21, 2024
@fktn-k fktn-k added this to the Release v0.3.12 milestone Sep 21, 2024
@fktn-k fktn-k self-assigned this Sep 21, 2024
Copy link

github-actions bot commented Sep 21, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 7fc54e5ed8502bdab7fe7a2ec5c3b2555d9a56ab.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr395.zip
ID 1960980366
URL https://github.com/fktn-k/fkYAML/actions/runs/10969411852/artifacts/1960980366

@fktn-k fktn-k merged commit f7bf317 into develop Sep 21, 2024
165 checks passed
@fktn-k fktn-k deleted the use_likely_unlikely_if_available branch September 21, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant