-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update/default-schema-change #11
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0946023
update/default-schema-change
fivetran-joemarkiewicz 7d16101
changelog pr ref update and template changes
fivetran-joemarkiewicz eef6275
window function partition fix
fivetran-joemarkiewicz 91dce2b
macro updates
fivetran-joemarkiewicz abd8ee5
working macro updates
fivetran-joemarkiewicz 9d47263
result_statement update
fivetran-joemarkiewicz cda0021
macro adjustments to not use booleans
fivetran-joemarkiewicz a9e448f
docs regen
fivetran-joemarkiewicz dfd3639
identifier in readme fix
fivetran-joemarkiewicz c7c7459
Update CHANGELOG.md
fivetran-joemarkiewicz c40a840
Update packages.yml
fivetran-joemarkiewicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
name: 'auto release' | ||
on: | ||
pull_request: | ||
types: | ||
- closed | ||
branches: | ||
- main | ||
|
||
jobs: | ||
call-workflow-passing-data: | ||
if: github.event.pull_request.merged | ||
uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main | ||
secrets: inherit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,4 +3,6 @@ target/ | |
dbt_modules/ | ||
logs/ | ||
.DS_Store | ||
dbt_packages/ | ||
dbt_packages/ | ||
env/ | ||
package-lock.yml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,13 +54,13 @@ Include the following Twitter Organic package version in your `packages.yml` | |
```yaml | ||
packages: | ||
- package: fivetran/twitter_organic | ||
version: [">=0.2.0", "<0.3.0"] # we recommend using ranges to capture non-breaking changes automatically | ||
version: [">=0.3.0", "<0.4.0"] # we recommend using ranges to capture non-breaking changes automatically | ||
``` | ||
Do NOT include the `twitter_organic_source` package in this file. The transformation package itself has a dependency on it and will install the source package as well. | ||
|
||
## Step 3: Configure Your Variables | ||
### Database and Schema Variables | ||
By default, this package will look for your Twitter Organic data in the `twitter_organic` schema of your [target database](https://docs.getdbt.com/docs/running-a-dbt-project/using-the-command-line-interface/configure-your-profile). If this is not where your Twitter Organic data is, add the following configuration to your `dbt_project.yml` file: | ||
By default, this package will look for your Twitter Organic data in the `twitter` schema of your [target database](https://docs.getdbt.com/docs/running-a-dbt-project/using-the-command-line-interface/configure-your-profile). If this is not where your Twitter Organic data is, add the following configuration to your `dbt_project.yml` file: | ||
|
||
```yml | ||
vars: | ||
|
@@ -69,7 +69,7 @@ vars: | |
``` | ||
|
||
## (Optional) Step 4: Additional Configurations | ||
<details><summary>Expand for configurations</summary> | ||
<details open><summary>Expand for configurations</summary> | ||
|
||
### Change the Build Schema | ||
By default, this package builds the GitHub staging models within a schema titled (<target_schema> + `_stg_twitter_organic`) in your target database. If this is not where you would like your GitHub staging data to be written to, add the following configuration to your root `dbt_project.yml` file: | ||
|
@@ -88,7 +88,7 @@ If an individual source table has a different name than the package expects, add | |
|
||
```yml | ||
vars: | ||
twitter_organic_<default_source_table_name>_identifier: your_table_name | ||
twitter_<default_source_table_name>_identifier: your_table_name | ||
``` | ||
|
||
### Unioning Multiple Twitter Organic Connectors | ||
|
@@ -120,7 +120,7 @@ This dbt package is dependent on the following dbt packages. Please be aware tha | |
```yml | ||
packages: | ||
- package: fivetran/twitter_organic_source | ||
version: [">=0.2.0", "<0.3.0"] | ||
version: [">=0.3.0", "<0.4.0"] | ||
|
||
- package: fivetran/fivetran_utils | ||
version: [">=0.4.0", "<0.5.0"] | ||
|
@@ -144,4 +144,3 @@ We highly encourage and welcome contributions to this package. Check out [this p | |
# 🏪 Are there any resources available? | ||
- If you encounter any questions or want to reach out for help, please refer to the [GitHub Issue](https://github.com/fivetran/dbt_twitter_organic/issues/new/choose) section to find the right avenue of support for you. | ||
- If you would like to provide feedback to the dbt package team at Fivetran, or would like to request a future dbt package to be developed, then feel free to fill out our [Feedback Form](https://www.surveymonkey.com/r/DQ7K7WW). | ||
- Have questions or want to just say hi? Book a time during our office hours [here](https://calendly.com/fivetran-solutions-team/fivetran-solutions-team-office-hours) or send us an email at [email protected]. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a line around the new automation release bot as it's a part of this PR.
Also the Secret needs to be added.
(Update looks like this was just added so all good here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-joemarkiewicz bumping this one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-catfritz this was already added