Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for upstream macro update #55

Merged
merged 6 commits into from
Mar 3, 2025
Merged

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Feb 25, 2025

PR Overview

This PR will address the following Issue/Feature: internal ticket

Submission Checklist

Submitter:

  • Alignment meeting with the reviewer
  • Provide validation details:
    • Validation Steps: Outline how to verify the changes -- provided in internal ticket
    • Testing Instructions: Clear steps for running/testing (e.g., scripts, sample data)
    • Focus Areas: Highlight any complex logic or queries needing special attention -- updates are within the macros

Reviewer:

  • Confirm submission requirements are met

Changelog

  • Draft after PR approval

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small adjustment

CHANGELOG.md Outdated
@@ -1,6 +1,8 @@
# dbt_iterable version.version
# dbt_iterable v0.13.1
[PR #55](https://github.com/fivetran/dbt_iterable/pull/55) includes the following updates:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't entirely accurate since there are other PR changes in this update as well. Let's move to the individual PR link per entry in this update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

packages.yml Outdated
Comment on lines 2 to 7
# - package: fivetran/iterable_source
# version: [">=0.10.0", "<0.11.0"]

- git: https://github.com/fivetran/dbt_iterable_source.git
revision: does_table_exist
warn-unpinned: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to update before merge

Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fivetran-reneeli fivetran-reneeli merged commit 370ba1e into main Mar 3, 2025
9 checks passed
@fivetran-reneeli fivetran-reneeli deleted the update_does_table_exist branch March 3, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants