feature/update-readme #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-catfritz
added
status:in_review
Closed
4 tasks
There was a problem hiding this comment.
@fivetran-catfritz Looks mostly good! A few changes might be needed but shouldn't take too long.
Also I don't think you need to add Github tags for the PRs. But make sure to add a priority tag to the original issue!
README.md
Outdated
Comment on lines
66
to
68
| Your Iterable connector might not sync every table that this package expects. If your syncs exclude certain tables, it is because you either don't use that functionality in Iterable or have actively excluded some tables from your syncs. In order to enable or disable the relevant functionality in the package, you will need to add the relevant variables. | ||
|
|
||
| By default, all variables are assumed to be `true` (with exception of `iterable__using_user_device_history`, which is set to `false`). You only need to add variables for the tables you would like to enable or disable respectively: |
There was a problem hiding this comment.
Same comment as the source package. Would recommend keeping the final sentence for one of the paragraphs, just not both!
packages.yml
Outdated
| - git: https://github.com/fivetran/dbt_iterable_source.git | ||
| revision: feature/update-readme | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Regular reminder to switch the packages back!
Co-authored-by: Avinash Kunnath <[email protected]>
fivetran-avinash
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
@fivetran-catfritz Approved, with one tweak and one important reminder to switch the packages back!
packages.yml
Outdated
| - git: https://github.com/fivetran/dbt_iterable_source.git | ||
| revision: feature/update-readme | ||
| warn-unpinned: false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
Fivetran created PR
What change(s) does this PR introduce?
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
✏️
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.