[Issue-109] Optimize int_hubspot__contact_merge_adjust for redshift users #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey thanks so much for opening this! this works perfectly for me on our (limited) sample data. curious- how much did this cut your own runtime? @kcraig-ats |
@fivetran-jamie runtime dropped from 15 minutes to ~1 minute. |
|
sick! i'll go ahead and merge into the release branch. thanks so much for contributing |
fivetran-jamie
approved these changes
Jun 7, 2023
|
@fivetran-jamie I saw the check failure. Did I do something wrong/ do I need to need to do anything more? |
|
ah no ignore that! it's just a reminder to us to regenerate docs before releasing |
This was referenced Jun 7, 2023
Merged
|
this is in v0.10.0 of the package! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide your name and company
Kris Craig, ActBlue
Link the issue/feature request which this PR is meant to address
Issue #109 - Poor performance on int_hubspot__contact_merge_adjust
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
Updated the unnest logic for redshift users in the
merge_contactsmacro. Replace cross join logic redshift's PartiQL syntax.How did you validate the changes introduced within this PR?
Tested locally with a custom model.
Which warehouse did you use to develop these changes?
Redshift
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Provide an emoji that best describes your current mood
🍙
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)