-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update versions of depedencies #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall approved! some little suggestions for the CHANGELOG and updating downstream package documentation
CHANGELOG.md
Outdated
# dbt_google_ads_source v0.9.4 | ||
|
||
## Under the Hood: | ||
- Updates the dbt-expectations dependency to the latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a link to https://github.com/calogica/dbt-expectations/releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-authored-by: Jamie Rodriguez <[email protected]>
PR Overview
This PR will address the following Issue/Feature:
#44
#39
This PR will result in the following new package version:
v0.9.4
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Run the google ads transforms with this branch
You'll need to add the following to the packages.yml:
Run the ad reporting package with this branch
You'll need to add the following to the packages.yml:
Standard Updates
Please acknowledge that your PR contains the following standard updates:
❗ Special Updates for Ad Reporting ❗
To reduce integration testing time, not all models should be enabled in the
run_models.sh
vars. Update the variables afterdbt run
anddbt test
to set:true
true
(if not already)false
Sdbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
💃