bug/databricks-target-database

[fivetran-catfritz]

PR Overview

This PR will address the following Issue/Feature:

• [Bug] Unable to define database variables using Unity Catalog for Google Ads Source dbt_ad_reporting#87

This PR will result in the following new package version:

• 9.2

• this is non-breaking since this is a setting update for databricks that does not affect the model outputs nor require additional configuration on the user's end.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

• This updates the below section of the src_google_ads.yml to remove databricks from the not in list.

sources:
  - name: google_ads
    schema: "{{ var('google_ads_schema', 'google_ads') }}"
    database: "{% if target.type not in ['spark', 'databricks'] %}{{ var('google_ads_database', target.database) }}{% endif %}"

• Databricks, unlike Spark, does have a target.database value and should not be excluded from having the value set. Users utilizing the Databricks unity catalog can experience issues when the database is not supplied a value.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• I used seed data for running in Databricks
• dbt compile
• dbt run –full-refresh
• dbt run
• dbt test Note--it is a known issue to get a regexp_instr failure for the 1st dbt_expectations test, but all other tests pass.
• dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked and tagged
• You are assigned to the corresponding issue and this PR
• BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

• You have validated these changes and assure this PR will address the respective Issue/Feature.
• You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• You have provided details below around the validation steps performed to gain confidence in these changes.

• Tested locally in google_ads_source, google_ads, and ad_reporting.
• User that created original issue confirms the fix as well.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • indexed within dbt_project.yml
  • indexed within integration_tests/dbt_project.yml
• CHANGELOG has individual entries for each respective change in this PR
• README updates have been applied (if applicable)
• DECISIONLOG updates have been updated (if applicable)
• Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

🧱

[fivetran-joemarkiewicz]

LGTM, just one small request to adjust wording in the readme